EntropyReader Class #5341
Merged
EntropyReader Class #5341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
RanpengLi
changed the title
|
@gassmoeller Hi Rene, I have modified it according to your comments for #5334. This one doesn't have the strange indents in #5334. |
|
/rebuild |
gassmoeller
reviewed
Aug 8, 2023
|
|
||
| /** | ||
| * This class reads in an entropy-pressure material table and looks up material | ||
| * proporties for the given entropy and pressure. |
There was a problem hiding this comment.
Suggested change
| * proporties for the given entropy and pressure. | |
| * properties for the given entropy and pressure. |
| const std::string material_file_name); | ||
|
|
||
| /** | ||
| * Reads the specific heat for a given entropy and pressure. |
There was a problem hiding this comment.
Reads is maybe not the correct work. What about:
Suggested change
| * Reads the specific heat for a given entropy and pressure. | |
| * Returns the specific heat for a given entropy and pressure. |
Same for all the other functions below.
source/material_model/utilities.cc
Outdated
| EntropyReader::compressibility(const double entropy, | ||
| const double pressure) const | ||
| { | ||
| const double compressibility = material_lookup->get_data({entropy,pressure}, 2); |
There was a problem hiding this comment.
This seems not correct. The thermal_expansivity above is also listed as column 2. Which one is it?
source/postprocess/command.cc
Outdated
| @@ -29,7 +29,7 @@ namespace aspect | |||
| Command<dim>::execute (TableHandler &) | |||
| { | |||
| if (on_all_processes || | |||
| (Utilities::MPI::this_mpi_process(this->get_mpi_communicator()) == 0)) | |||
There was a problem hiding this comment.
Are these dealii:: prefixes here and in the other instances still necessary? I though the using statements had fixed that?
RanpengLi
force-pushed
the
entropy-reader-new
branch
from
f30feb9
to
b68aa12
Compare
|
Thank you! I have addressed the comments and squashed the previous commits into one. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opened up this pull request to test and fix some issues in my last pull request (#5334 Add EntropyReader Class). The previous one couldn't compile on the testers, but it could on my up-to-date local version. It also seems to have some strange indents.