Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

require SUNDIALS and deal.II 9.5 #5367

Merged
merged 5 commits into from Feb 7, 2024
Merged

require SUNDIALS and deal.II 9.5 #5367

merged 5 commits into from Feb 7, 2024

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Aug 16, 2023 •
edited

I am not sure if we should delay merging this a bit further, but it would be great to have this in place at some point so we can start merging features requiring it and so we can test installation instructions, CI, etc..

@tjhei tjhei mentioned this pull request Aug 16, 2023
Open
@gassmoeller
Copy link
Member

I would prefer if we can combine this change with the switch to requiring deal.II 9.5. That way users will only have to install a new deal.II version once. The first step for that would be to start a new reference tester with 9.5 and include that in the CI.

@tjhei tjhei changed the title require SUNDIALS require SUNDIALS and deal.II 9.5 Aug 20, 2023
@tjhei
Copy link
Member Author

tjhei commented Aug 20, 2023

Sure. :-)

@tjhei
Copy link
Member Author

tjhei commented Aug 20, 2023

We need for deal.II packaging of 9.5 to finish first...

bangerth
bangerth approved these changes Aug 31, 2023
View reviewed changes
Copy link
Contributor

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve now already, even though I know that this shouldn't yet be merged.

It would probably be nice (here or in a follow-up) to also output SUNDIALS version information in source/global.cc in the print_aspect_header() function in the same way as we do for the other dependencies.

@gassmoeller gassmoeller mentioned this pull request Sep 9, 2023
Merged
@gassmoeller gassmoeller mentioned this pull request Oct 7, 2023
Merged
@bangerth
Copy link
Contributor

bangerth commented Oct 8, 2023

What's our timeline for this?

@gassmoeller
Copy link
Member

soonish. the only missing piece is to switch our reference tester results to the new 9.5 tester.

@gassmoeller gassmoeller mentioned this pull request Nov 16, 2023
Merged
@gassmoeller gassmoeller mentioned this pull request Feb 6, 2024
Merged
@gassmoeller
Copy link
Member

@bangerth @tjhei This should now be ready to merge.

tjhei
tjhei commented Feb 7, 2024
View reviewed changes
Copy link
Member Author

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @bangerth ?

@bangerth bangerth merged commit 990e2ef into geodynamics:main Feb 7, 2024
7 checks passed
@tjhei tjhei deleted the require-sundials branch February 8, 2024 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangerth bangerth bangerth approved these changes

Assignees
No one assigned
Labels
ready to merge ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tjhei @gassmoeller @bangerth