add viscosity profile that is more consistent with original Steinberg… #5372
Conversation
jdannberg
force-pushed
the
steinberger_continuous_viscosity
branch
2 times, most recently
from
67c89b9
to
778dbad
Compare
…er and Calderwood formulation
jdannberg
force-pushed
the
steinberger_continuous_viscosity
branch
from
778dbad
to
5be681b
Compare
There was a problem hiding this comment.
Thank you for fixing this! The PR looks good, I just marked some small possible improvements. As far as I understand we prefer the new profile as a more faithful representation of the original paper. Should we make this more clear in the cookbook description so that users will preferentially use the new profile? Maybe make the new profile the default in the material model? (this would change user models, so maybe not?) Not sure what the best path is, let me know what you think.
| optimize them based on observational data. During this optimization, the different | ||
| layers that make up the profiles (usually lithosphere, upper mantle, transition | ||
| zone, and lower mantle) are shifted left or right relative to each other. | ||
| The figures that show these optizimed profiles in the paper represent them as |
There was a problem hiding this comment.
| The figures that show these optizimed profiles in the paper represent them as | |
| The figures that show these optimized profiles in the paper represent them as |
| layers that make up the profiles (usually lithosphere, upper mantle, transition | ||
| zone, and lower mantle) are shifted left or right relative to each other. | ||
| The figures that show these optizimed profiles in the paper represent them as | ||
| piece-wise constant within 22 layers, and the profiles shown in Figures |
There was a problem hiding this comment.
| piece-wise constant within 22 layers, and the profiles shown in Figures | |
| piece-wise constant values within 22 layers, and the profiles shown in Figures |
| @@ -0,0 +1,5 @@ | |||
| New: There is now a new viscosity profile data file that | |||
| is more consistent with how the profile is computed in | |||
| the original Steinberger and Calderwood paper. | |||
There was a problem hiding this comment.
| the original Steinberger and Calderwood paper. | |
| the original Steinberger and Calderwood (2006) paper. |
|
I addressed your comments. But I added a sentence that we recommend the new profile. |
…er and Calderwood formulation
This is based on a conversation with Bernhard Steinberger, who sent me this file, noting that it is more consistent with the profiles computed in his paper.
I have also updated the cookbook to show the difference between the profiles.
For all pull requests:
For new features/models or changes of existing features: