add notebook for grain size plunge #5376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
reviewed
Aug 31, 2023
| { | ||
| "cell_type": "markdown", | ||
| "source": [ | ||
| "This is the same field boundary grain size that is plotted in Figure 4 of Mulyokiva & Bercovici (1.6e-5 m). Note that we still had to convert from roughness to grain size after calculating $r_f$ from their equation (8), so their naming scheme is a bit misleading (one would expect it to be field boundary roughness, not grain size)." |
There was a problem hiding this comment.
Suggested change
| "This is the same field boundary grain size that is plotted in Figure 4 of Mulyokiva & Bercovici (1.6e-5 m). Note that we still had to convert from roughness to grain size after calculating $r_f$ from their equation (8), so their naming scheme is a bit misleading (one would expect it to be field boundary roughness, not grain size)." | |
| "This is the same field boundary grain size that is plotted in Figure 4 of Mulyukova & Bercovici (1.6e-5 m). Note that we still had to convert from roughness to grain size after calculating $r_f$ from their equation (8), so their naming scheme is a bit misleading (one would expect it to be field boundary roughness, not grain size)." |
| "output_type": "stream", | ||
| "name": "stdout", | ||
| "text": [ | ||
| "residual: 4164445.1831699545\n", |
There was a problem hiding this comment.
Please remove the outputs from the jupyter notebook.
| { | ||
| "cell_type": "markdown", | ||
| "source": [ | ||
| "Again, our viscosity (2.89e18 Pa s) is similar but slightly smaller than what is plotted in the figure (approximately 3.4e18 Pa s). This is expected, since we are in the diffusion creep regime, where a lower grain sizes reduces the viscosity." |
There was a problem hiding this comment.
Suggested change
| "Again, our viscosity (2.89e18 Pa s) is similar but slightly smaller than what is plotted in the figure (approximately 3.4e18 Pa s). This is expected, since we are in the diffusion creep regime, where a lower grain sizes reduces the viscosity." | |
| "Again, our viscosity (2.89e18 Pa s) is similar but slightly smaller than what is plotted in the figure (approximately 3.4e18 Pa s). This is expected, since we are in the diffusion creep regime, where a lower grain size reduces the viscosity." |
| { | ||
| "cell_type": "markdown", | ||
| "source": [ | ||
| "We can see that the results given in the paper only approximately fuflfil the equation.\n", |
There was a problem hiding this comment.
Suggested change
| "We can see that the results given in the paper only approximately fuflfil the equation.\n", | |
| "We can see that the results given in the paper only approximately fulfil the equation.\n", |
|
Thank you for finding all my typos! I've fixed those, but I have left the output in the notebook, since that allows it to view the correct test results in the browser just by opening the file, without actually having to run the output. I thought this would be useful for easily comparing the notebook and the ASPECT results. |
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #5363 that adds documentation. Specifically, it adds a jupyter notebook that computes the analytical solution that the benchmark reproduces.
For all pull requests: