Rework Blankenbach and King benchmarks to compare heat flux postprocessor methods. #5378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Aug 30, 2023
There was a problem hiding this comment.
should the legend h, h^2, h^3 instead of x?
There was a problem hiding this comment.
I can update that. Will have to wait until tomorrow though, we shut down all computers in the lab due to the hurricane. I will let you know when its ready.
gassmoeller
force-pushed
the
heat_flux_comparison_cbf_gradient
branch
from
f18771f
to
b274dfa
Compare
|
I rebased, squashed the commits and updated the figures as requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the changelog entry, this is a rework of the
blankenbachandking2dcompressiblebenchmarks. I didnt change the setups themselves, except for adding the old way of computing heat flux values (from before #2675) for comparison and in addition to the current heat flux postprocessor (this comparison was the main purpose I started this). The new heat flux plugin for the benchmarks is exactly the old state of the heat flux before #2675 with some minor modifications I had to make to get it to work in main.Other changes are:
I removed the existing
Makefile, shell scripts, and the LibreOffice table. I don't think hand written Makefiles are very readable (I found it very hard to follow), and it surprised me to see we included .ods files (even though I added this myself :-)). I also converted the README files into markdown files and included them in the documentation, so that we now have two new benchmark sections.I am open to suggestions for improvements. I know we lost a few features with the new scripts (e.g. you cannot run individual cases without modifying the script, which was possible before), but I find it way more intuitive to read and think most of our users will prefer python scripts to Makefile syntax.