Loosen tolerance for particle interpolation limiter #5386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I occasionally observe crashes with the particle limiter option that claim that the particle limiter did not succeed. I was finally able to track one down in the debugger and it seems that it only happens if the property to interpolate is essentially constant, and the tolerance is just barely exceeded (in my case 2e-9 instead of the 1e-9 tolerance we prescribe). This PR loosens the tolerance a bit (to around 2e-8) and binds it to the accuracy of the floating point number type used, which should hopefully take care of this.
Also improve the error output.