Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update global melt cookbook #5388

Merged
merged 1 commit into from Sep 14, 2023

Conversation

jdannberg
Copy link
Contributor

At the moment, this cookbook crashes on main (after a few time steps).
This fix is in response to https://community.geodynamics.org/t/problems-with-global-melt-cookbook/3043 and https://community.geodynamics.org/t/unable-to-reproduce-global-melt-cookbook-results-in-the-aspect-manual/3093.
As mentioned on the forum, I believe this is because of our changes to the artificial diffusion.

To make the cookbook work again, I

  • increased the resolution
  • refined the mesh near the top and bottom
  • increased the temperature and age of the bottom boundary (we had more conduction before with the old artificial viscosity, so the plumes on the current main are thinner/colder than they used to be, and this makes them hotter again so that there actually is some melting)
  • increased the end time

I updated the figure in the cookbook accordingly. I also updated the prm files in the doc folder, which are just copies of parts of the actual cookbooks. Those had gotten out of date as well, so the typo/documentation changes in those files are just because I copied over the actual cookbook prm files.

Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for fixing.

@gassmoeller gassmoeller merged commit 27fa159 into geodynamics:main Sep 14, 2023
7 checks passed
@jdannberg jdannberg deleted the update_melt_globaL_cookbook branch September 14, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants