[WIP] move particle parameters into their own top-level subsection #5394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gassmoeller
force-pushed
the
update_particle_parameters
branch
from
f6a094a
to
3238e08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends #5381 to perform one of the updates we discussed for 3.0: To put the particle input parameters in their own top level subsection and disentangle the use of "Number of particles" parameter between different particle generators (move it into specific subsections).
This is WIP, because I need to check the tests and also want to do some upgrades to the older update scripts before merging this one (once this is merged many users will have to use the update script, and some of our older update scripts dont work anymore, we should remove them).