Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastscape: Rename Qtrapez function, fix some warnings, and add stabilization flag. #5530

Merged
merged 1 commit into from Dec 25, 2023

Conversation

Djneu
Copy link
Contributor

@Djneu Djneu commented Dec 19, 2023

Hi all, here are some minor changes to the fastscape plugin to fix some warnings and rename Qtrapez to Qtrapezoid. Also, this adds the flag so the plugin can use the free surface stabilization.

Pull Request Checklist. Please read and check each box with an X. Delete any part not applicable. Ask on the forum if you need help with any step.

Describe what you did in this PR and why you did it.

Before your first pull request:

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@Djneu Djneu changed the title Rename Qtrapez function, fix some warnings, and add stabilization flab. Fastscape: Rename Qtrapez function, fix some warnings, and add stabilization flab. Dec 19, 2023
@Djneu Djneu changed the title Fastscape: Rename Qtrapez function, fix some warnings, and add stabilization flab. Fastscape: Rename Qtrapez function, fix some warnings, and add stabilization flag. Dec 19, 2023
@tjhei
Copy link
Member

tjhei commented Dec 24, 2023

/rebuild

@tjhei tjhei merged commit 800e803 into geodynamics:main Dec 25, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants