Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use apt packaged cmake version in tester #5562

Merged
merged 1 commit into from Feb 2, 2024

Conversation

gassmoeller
Copy link
Member

We have some unexplained test failures in the indent tester in the compile stage (see e.g. #5560
). After some investigation I found this: It looks like the new cmake (3.28.2) version that was included in the github actions runner yesterday broke the compatibility of precompiled headers and unity builds (see discussion here). cmake 3.28.3 should fix this, but who knows when it will be released and deployed in the actions runner. Therefore this PR tries to circumvent the problem by using the apt packaged version of cmake on the runner (that we install anyway). If this works the tester should now use cmake 3.16 which comes with ubuntu 20.04. We can revert this change later.

@bangerth
Copy link
Contributor

bangerth commented Feb 2, 2024

Ah, good job. I tried to understand the failure in #5560 but could not make sense of it.

@gassmoeller
Copy link
Member Author

Yup, it reminded me of an earlier case we had last year, that is how I figured it out. Also it looks like it is working, the indent+documentation tester passed. Let's wait for the rest of the testers.

@bangerth bangerth merged commit 84d4257 into geodynamics:main Feb 2, 2024
8 checks passed
@gassmoeller gassmoeller deleted the fix_tester_cmake branch February 5, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants