disable FPE around boost call #754
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: there are more calls to spherical_harmonic_r in the code but I would like to test this first. Do not merge yet. |
some versions of boost generate an FPE in boost::math::spherical_harmonic_r so we disable floating point exceptions around it for now.
tjhei
force-pushed
the
spherical_harmonic_fpe
branch
from
b847200
to
49836f1
Compare
| #ifdef ASPECT_USE_FP_EXCEPTIONS | ||
| #include <fenv.h> | ||
| #endif | ||
| #endif |
There was a problem hiding this comment.
Can you nest these preprocessor commands via indentation, e.g.
#ifdef ...
# ifdef ...
# include ...
eadeb4a
to
55c9b04
Compare
tjhei
force-pushed
the
spherical_harmonic_fpe
branch
from
55c9b04
to
11e7342
Compare
|
As I've mentioned on other occasions, I tend to think that this is not a scalable solution. If a particular call to a function gives us trouble, then we should add that call to the cmake test and just disable FPEs altogether on that system, based on the assumption that if one call is problematic then others will likely be as well. |
|
In an effort to clean up the pull request data base, let me close this -- it seems to me that we don't have a clear path forward with this PR. We can always open it at a later time again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some versions of boost generate an FPE in
boost::math::spherical_harmonic_r so we disable floating point
exceptions around it for now.