Earlier signal creation #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- move signal creation up Conflicts: source/simulator/core.cc
|
this is extracted from #772 |
| void call_connector_functions (aspect::SimulatorSignals<2> &signals); | ||
| void call_connector_functions (aspect::SimulatorSignals<3> &signals); | ||
| template <int dim> | ||
| void call_connector_functions (aspect::SimulatorSignals<dim> &signals_); |
There was a problem hiding this comment.
Is this underscore necessary?
There was a problem hiding this comment.
You don't. The name is silent anyway.
|
I like it. Except for the one naming issue this seems good to go. I would suggest you wait over the weekend in case @bangerth has comments, but I would say feel free to merge afterwards. Not many controversial things anyway. |
| @@ -72,6 +56,8 @@ namespace aspect | |||
| const unsigned int max_part_per_cell, | |||
| const unsigned int weight) | |||
| { | |||
| World<dim>::connect_to_signals(this->get_signals()); | |||
There was a problem hiding this comment.
No need to qualify the class name here
|
Please address the minor issues and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch moves the creation of the
signalsobject closer to the top of the simulator and call the connector functions as soon as possible (instead of at the end of the initialization). In the future, this will allow us to fire new signals during introspection construction for example. Right now this doesn't do anything exciting.