always print cheap Stokes solver iterations #787
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is based on my suggestion, because I got confused when we were looking at output and we couldn't tell if "X iterations" meant cheap or expensive iterations. I assume we need to fix a lot more of those tests... |
|
/run-tests |
|
The patch is ok if you fix the failing tests (e.g., by further adapting the script that filters/processes output before comparing). |
This contains mostly "+0" changes, but also: - small changes within epsilon (that numdiff accepts as okay). The new numbers are the ones found by the tester. - removal of timing output - small formatting changes (whitespace)
|
okay, tests are passing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.