Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not classname-qualify members of enums. #809

Merged
merged 1 commit into from Apr 7, 2016

Conversation

bangerth
Copy link
Contributor

@bangerth bangerth commented Apr 7, 2016

This is only allowed in C++11, whereas in C++98 the names of members of an enum
are only part of the enclosing namespace, but not members of the enum's namespace
itself.

This is only allowed in C++11, whereas in C++98 the names of members of an enum
are only part of the *enclosing* namespace, but not members of the enum's namespace
itself.
@bangerth
Copy link
Contributor Author

bangerth commented Apr 7, 2016

I should say that I needed to qualify the names by the namespace-name because there is also a function initialize in the class where I use these names. Consequently, leaving them unqualified left things ambiguous for the initialize case. I chose to also namespace-qualify the other uses of the enum members then.

@gassmoeller
Copy link
Member

Thanks for fixing!

@gassmoeller gassmoeller merged commit 66f92e3 into geodynamics:master Apr 7, 2016
@bangerth bangerth deleted the fix-c++11ism branch April 7, 2016 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants