Avoid warning about potentially unused variable. #820
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In optimized mode, we did not check that a point at which we want to evaluate the solution was actually found. This led to a warning about an unused variable 'point_found'. This could be addressed by doing a 'void' cast of said variable, but the better solution appears to be to actually perform the check also in optimized mode -- after all, the list of points at which we want to evaluate the solution is read at run-time from the input field.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In optimized mode, we did not check that a point at which we want to evaluate
the solution was actually found. This led to a warning about an unused
variable 'point_found'. This could be addressed by doing a 'void' cast
of said variable, but the better solution appears to be to actually
perform the check also in optimized mode -- after all, the list of points
at which we want to evaluate the solution is read at run-time from the
input field.