Require deal.II 8.4.1 #878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(do not merge yet, I want to make sure everything is working correctly) |
|
Alternatively: we currently output a lot of data with six digits. So any small change is on a relative order of slightly larger than 1e-6. That's why the new tester has so many failing tests. We could just up the relative tolerance for numdiff to 1e-5 and avoid this unfortunate mismatch for now and future cases. |
|
Many changes are number of linear iterations, unfortunately. |
|
Yes, we can't do much about that. Do you have a sense whether iterations tend to go up or down? |
Sometimes more, sometimes less. Differences are minor, though. See f61a83b |
|
okay, I think this is good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will switch the required deal.II version to 8.4.1 and update the test results such that the 8.4.1 tester will pass. Consequently, this will break the output for the old tester based on 8.2.1.