Remove old deal.II compatibility code #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove all code introduced to be backwards compatible with older deal.II versions.
| @@ -39,6 +39,7 @@ | |||
|
|
|||
| #include <deal.II/base/mpi.h> | |||
| #include <deal.II/base/multithread_info.h> | |||
| #include <deal.II/base/std_cxx11/unique_ptr.h> | |||
There was a problem hiding this comment.
Do you think it is necessary to include the unique_ptr here? It is only used in a few places, so should we include it only there? I am just asking, because it somehow feels out of place here (there is no inclusion of the other cxx11 features).
There was a problem hiding this comment.
it was unconditionally included in compat.h, but you are right, it seems to work without. Let's see if the tester agrees.
|
Except for the one question good to go. Just make a decision about that and then feel free to merge. |
|
Looks like it is working! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all code introduced to be backwards compatible with older deal.II
versions.