move traction boundary conditions to new interface #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdannberg
force-pushed
the
traction_interface
branch
2 times, most recently
from
ba41a67
to
0188040
Compare
| * Call the old-style function without the boundary id to maintain backwards | ||
| * compatibility. Normally the derived class should override this function. | ||
| */ | ||
|
|
There was a problem hiding this comment.
make this a regular //-style comment and omit the empty line between comment and code.
There was a problem hiding this comment.
Okay, done. I also changed it in the interface.cc of the velocity boundary conditions, because that's where I stole it from ;-)
Just waiting for the tester.
|
Looks good. Please address the one issue and merge yourself. |
jdannberg
force-pushed
the
traction_interface
branch
from
0188040
to
5ce251d
Compare
jdannberg
force-pushed
the
traction_interface
branch
from
5ce251d
to
a7dc4f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the traction boundary conditions do not get the boundary indicator when they are called (but only the position and the normal). As different boundaries can have different boundary traction plugins, it is useful to also hand over the boundary indicator (just as we do for velocity boundary conditions).
This pull request updates the interface of the traction boundary conditions.