A fix to postprocessers which crash with deal.ii 8.5.0-pre. #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! /run-tests |
| @@ -153,7 +153,7 @@ namespace aspect | |||
| local_values.push_back (local_boundary_fluxes[*p]); | |||
|
|
|||
| // then collect contributions from all processors | |||
| std::vector<double> global_values; | |||
| std::vector<double> global_values (local_values.size()); | |||
There was a problem hiding this comment.
can you please change this to a single space after the variable name?
…ing the vectors used for MPI function to the correct size.
MFraters
force-pushed
the
postprocessor_fix
branch
from
ff73d53
to
926874a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing the vectors used for MPI function to the correct size to prevent crashes as described in #909.
I checked most post-processors (basic statistics, boundary densities, boundary pressures, composition statistics, depth average, dynamic topography, heat flux statistics, heating statistics, mass flux statistics, point values, pressure statistics, Stokes residual, temperature statistics, velocity boundary statistics, velocity statistics, viscous dissipation statistics,visualization) by running them. I but I didn't run command, spherical velocity statistics and topography (only checked out the code), because they where incompatible with the model I was testing it with and I assumed that spherical velocity statistics, topography are in the testing package anyway because they are fairly new and command doesn't seem to use a MPI all_reduce (sum, min, max).