WIP: Add topography options to ellipsoidal geometry model #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s geometry model.
Fix spelling test
Fix bracket Change from file topography type names
Fix minor spelling and rename topo types
Name fix and add todo.
Add and rename nonuniform grid
Changing to pointer interface to store uniform or nonuniform grid.
…psoid_topo Conflicts: include/aspect/geometry_model/ellipsoidal_chunk.h source/geometry_model/ellipsoidal_chunk.cc
Add value function to uniform grid Clean up Astyle
Ellipsoid topo from nonuniform grid file and tests
| @@ -16,19 +16,21 @@ | |||
| You should have received a copy of the GNU General Public License | |||
| along with ASPECT; see the file doc/COPYING. If not see | |||
| <http://www.gnu.org/licenses/>. | |||
| */ | |||
| */ | |||
…psoid_topo Conflicts: include/aspect/geometry_model/ellipsoidal_chunk.h source/geometry_model/ellipsoidal_chunk.cc
Ellipsoid topo
|
Menno, let us know when we should take another look! /run-tests |
|
Yes, I would guess so. I wasn't aware any more that I had this one. I will close it therefore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anne and I are working on adding topography to the ellipsoidal geometry model. The work on it hasn't finished yet (nor fully clean or squashed), but we wanted to make sure people could see it before the beginning of the hackaton, hence the pull request. Comments are of course always welcome!