Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed workaround that included vector_tools.templates.h in freesurf… #946

Merged
merged 1 commit into from Jun 24, 2016

Conversation

spco
Copy link
Contributor

@spco spco commented Jun 24, 2016

…ace.cc. I don't think it was ever truly needed.

…ace.cc. I don't think it was ever truly needed.
@bangerth
Copy link
Contributor

Can you trace back on whose request this was put in? Maybe we can ask them to test with their current setup?

@spco
Copy link
Contributor Author

spco commented Jun 24, 2016

It was on my request! #641 I later came back to it a couple of months ago with a complete rebuild and never had the same problem - I forget what it was that I decided I'd done wrong in my previous setup, even when I thought I'd done a complete rebuild. Something in my Xcode setup I believe.

@bangerth
Copy link
Contributor

In that case we should merge! :-)

First one to see that the tester is happy push "merge"!

@bangerth
Copy link
Contributor

/run-tests

@spco
Copy link
Contributor Author

spco commented Jun 24, 2016

Looks good to merge!

@bangerth bangerth merged commit 808fd06 into geodynamics:master Jun 24, 2016
@spco spco deleted the remove_vectortools_workaround branch June 24, 2016 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants