Remove deprecated 'temperature' and 'composition' #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-tests |
|
Thanks for working on this. This relates to #943. When the tester succeeds this should be ready to go. |
spco
changed the title
|
Ready to merge if there's no comments! |
|
In a separate patch, can you add an entry to the changes.h file that explains this change? |
|
We already had an entry about this change when we deprecated the functions (prior to 1.4). Should we again mention that we now removed the deprecated functionality? |
|
There are a couple of other functions |
|
The order doesn't matter to me, but I think it should me mentioned in the change log file again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces them with
boundary_temperatureandboundary_composition, as brought in with #689 . Contributes towards #943