Use spherical coordinates for chunk as well in ascii data boundary #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you squash the two commits? (Or us "fixup"?) If you need help, let me know! |
|
/run-tests |
|
Otherwise ok to merge for the first one to come by here. |
anne-glerum
force-pushed
the
chunk_ascii_boundary
branch
from
4a567de
to
43bd604
Compare
|
Anne could you also copy one of the existing tests for the spherical shell and change it to Chunk? Otherwise we do not know if something breaks with AsciiData and Chunk. Ready to merge as soon as we have a working test. |
|
Added four AsciiData Chunk tests, ready for review. |
|
please update the test results with the tester results. ready to merge otherwise |
anne-glerum
force-pushed
the
chunk_ascii_boundary
branch
from
d1700d9
to
a0bbebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.