Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid --user to support virtualenv #48

Closed
wants to merge 1 commit into from

Conversation

jedbrown
Copy link

@jedbrown jedbrown commented Jun 2, 2021

No description provided.

@baagaard-usgs
Copy link
Contributor

This seems to only work for some installs.

We need a robust way to install to a specific directory that supports current Python module installation methods like Pip.

@jedbrown
Copy link
Author

jedbrown commented Jun 3, 2021

I think the centos-8 failure is a result of a pip that is older than 20.0.

Default to doing a user install (as if --user was passed) when the main site-packages directory is not writeable and user site-packages are enabled. -- https://pip.pypa.io/en/stable/news/#id303

Would you be willing to update pip in that container? Or activate a virtualenv in the default environment (which is what anyone setting up a non-containerized environment should want to do).

@baagaard-usgs
Copy link
Contributor

Activating a virtualenv would lead to adding a virtualenv in the binary package too.

I can try a newer pip, but I think I tried 21.0 in a different situation and still had problems with things not ending up in the correct place.

@jedbrown
Copy link
Author

You mean that the virtualenv would need to be activated to run pylith? That seems ... fine. It's a development environment.

@baagaard-usgs
Copy link
Contributor

Addressed in PR #55

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants