Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use freq_gradsmooth to guide setting time window duration #102

Merged
merged 2 commits into from
Nov 10, 2021
Merged

Conversation

wliuphd
Copy link
Collaborator

@wliuphd wliuphd commented Nov 1, 2021

Updates to generate travel times properly when using the Dirac source time function.

Copy link
Contributor

@bjorn2 bjorn2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Wei,
Just one question. It looks as if you have added a frequency input parameter freq_gradsmooth, that is used to modify the source frequency in the eikonal solver. That is fine, I can see why that is needed, but why the name "gradsmooth" ? It does not seem to have anything to do with smoothing the gradient.
/Bjorn

@wliuphd
Copy link
Collaborator Author

wliuphd commented Nov 8, 2021

Bjorn,

The parameter freq_gradsmooth was originally used to calculate spatial scales needed for smoothing gradients. It is also used for gauging time window durations here when source frequency can be subject to different scales and changes form different source time functions.

@andersp
Copy link
Contributor

andersp commented Nov 8, 2021 via email

@wliuphd
Copy link
Collaborator Author

wliuphd commented Nov 8, 2021

How about renaming freq_gradsmooth to freq_peakpower?

@andersp
Copy link
Contributor

andersp commented Nov 8, 2021

@wliuphd That name makes more sense to me.

@wliuphd
Copy link
Collaborator Author

wliuphd commented Nov 9, 2021

@bjorn2 , I have updated PR with renaming the parameter. Can you merge it since I don't have write access.

@bjorn2 bjorn2 merged commit d1e47a3 into developer Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants