Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow different projection on overview map #222

Merged
merged 6 commits into from Feb 15, 2017

Conversation

buehner
Copy link
Contributor

@buehner buehner commented Dec 14, 2016

I noticed that the overview map requires the same projection as the parent map.

This PR allows the overview map to use a projection that differs from the parent maps projection.

Changes basically include the transformation of coordinates/geoms, if necessary. To assure that the magnification mechanism also works initially, some effort was necessary (as resolutions had to be available on the overviewView).

Note: Tests are still missing. I'll soon try to add some.

@marcjansen
Copy link
Member

marcjansen commented Dec 14, 2016

Looking slick so far, nice job. I'll give this a proper review, once tests have been added.

@marcjansen
Copy link
Member

Will you continue work on this, @buehner?

@buehner buehner force-pushed the different-overview-projection branch from c20f7e3 to cbb87f2 Compare January 9, 2017 13:17
@buehner
Copy link
Contributor Author

buehner commented Jan 9, 2017

Since #225 extended the functionality of the overview map, i think this PR needs some adaptions now.

Could not get your drag feature work in combination with a different projection yet. I'll have a look at his now.

@buehner
Copy link
Contributor Author

buehner commented Jan 10, 2017

I adapted the code:

  • the boxCenter will be transformed if necessary when it is dragged
  • the box will rendered initially
  • the updateBox function will be disabled during the drag (as it interferes sometimes with the dragging)

Unfortunately it is not so easy to transform the whole box geometry when it is dragged (maybe someone has a good idea how to do this), but the drag feature is still easy to use.

I'll try to add some tests now.

@marcjansen
Copy link
Member

marcjansen commented Jan 10, 2017

Still looks great. Once tests are there, I will have another look.

@chrismayer
Copy link
Contributor

Any news here?

@buehner
Copy link
Contributor Author

buehner commented Jan 30, 2017

There are still some tests missing. I did not yet find the time to add them, but i'll try to add them as soon as possible

@buehner buehner force-pushed the different-overview-projection branch from fb9ed58 to e467ee0 Compare February 15, 2017 13:29
@buehner
Copy link
Contributor Author

buehner commented Feb 15, 2017

I added a test in e467ee0

@buehner
Copy link
Contributor Author

buehner commented Feb 15, 2017

The tests fail now due to the issue mentioned in #242

As soon as #242 is merged, i can rebase this one here to make it green!

@marcjansen
Copy link
Member

LGTM. I'll merge once rebased.

@buehner buehner force-pushed the different-overview-projection branch from e467ee0 to 4fb09cc Compare February 15, 2017 13:55
@buehner
Copy link
Contributor Author

buehner commented Feb 15, 2017

I rebased! Now everything is green again...

@marcjansen marcjansen merged commit 4fdf06b into geoext:master Feb 15, 2017
@marcjansen
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants