New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow different projection on overview map #222
Allow different projection on overview map #222
Conversation
Looking slick so far, nice job. I'll give this a proper review, once tests have been added. |
Will you continue work on this, @buehner? |
c20f7e3
to
cbb87f2
Compare
Since #225 extended the functionality of the overview map, i think this PR needs some adaptions now. Could not get your drag feature work in combination with a different projection yet. I'll have a look at his now. |
I adapted the code:
Unfortunately it is not so easy to transform the whole box geometry when it is dragged (maybe someone has a good idea how to do this), but the drag feature is still easy to use. I'll try to add some tests now. |
Still looks great. Once tests are there, I will have another look. |
Any news here? |
There are still some tests missing. I did not yet find the time to add them, but i'll try to add them as soon as possible |
fb9ed58
to
e467ee0
Compare
I added a test in e467ee0 |
LGTM. I'll merge once rebased. |
This is necessary if the overview map is initially hidden and becomes visible later.
e467ee0
to
4fb09cc
Compare
I rebased! Now everything is green again... |
Thanks again! |
I noticed that the overview map requires the same projection as the parent map.
This PR allows the overview map to use a projection that differs from the parent maps projection.
Changes basically include the transformation of coordinates/geoms, if necessary. To assure that the magnification mechanism also works initially, some effort was necessary (as resolutions had to be available on the overviewView).
Note: Tests are still missing. I'll soon try to add some.