Publish only tagged packages #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we would publish a sencha package for every commit that happened in the `master`-branch. This commit changes this in a way that only tagged commits (released versions) will publish a sencha package. We still need to define how we actually want to react when we build for say `v3.0.1`. The current approach would probably make the originally published `v3.0.0` unusable (because we `rm` probably too much, and also copy over `catalog.json` metatdata files where we actually want to merge new `catalog.json` with existing ones). An upcoming commit will temporary disable the publishing alltogether, so we cannot break the existing published package.
We disable the publishing of the sencha package until we know what we need to do in order to be able to publish e.g. `v3.0.1` when we already have a `v3.0.0`.
marcjansen
force-pushed
the
publish-only-tagged-packages
branch
from
21299d8
to
e2075c6
Compare
marcjansen
changed the title
|
We have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is WIP until we have released
v3.0.0.Previously we would publish a sencha package for every commit that
happened in the
master-branch. This commit changes this in a waythat only tagged commits (released versions) will publish a sencha
package.
We still need to define how we actually want to react when we build
for say
v3.0.1. The current approach would probably make theoriginally published
v3.0.0unusable (because wermprobably toomuch, and also copy over
catalog.jsonmetatdata files where weactually want to merge new
catalog.jsonwith existing ones).Comit 21299d8 temporary disables the publishing alltogether,
so we cannot break any existing published package.