Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Followup for layer synchronization #688

Merged
merged 2 commits into from
May 28, 2021
Merged

Followup for layer synchronization #688

merged 2 commits into from
May 28, 2021

Conversation

simonseyock
Copy link
Member

@simonseyock simonseyock commented May 27, 2021 •
edited
Loading

This is a follow up to #683

It merges two functions and makes a function call clearer.

Also this uses the filter function only in onChangeLayer as before.

@simonseyock simonseyock mentioned this pull request May 27, 2021
Merged
@coveralls
Copy link

coveralls commented May 27, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 882679577

  • 9 of 10 (90.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.05%) to 81.401%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/data/store/Layers.js 9 10 90.0%
Totals Coverage Status
Change from base Build 875842281: -0.05%
Covered Lines: 1387
Relevant Lines: 1627
💛 - Coveralls

@simonseyock simonseyock merged commit 78dfb57 into master May 28, 2021
@simonseyock simonseyock deleted the synchronize-layers branch May 28, 2021 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbllmnn hwbllmnn hwbllmnn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@simonseyock @coveralls @hwbllmnn