Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a hit tolerance to feature selection model. #690

Merged
merged 5 commits into from
Jun 10, 2021

Conversation

simonseyock
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented Jun 8, 2021

Pull Request Test Coverage Report for Build 924231335

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 81.177%

Totals Coverage Status
Change from base Build 885980754: 0.1%
Covered Lines: 1383
Relevant Lines: 1630

💛 - Coveralls

Copy link
Contributor

@chrismayer chrismayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me. Please have a look at the failing tests...not sure if this is related or not.

@simonseyock
Copy link
Member Author

I had to improved the test :D

@simonseyock
Copy link
Member Author

I also fixed an error with destroying an associated grid. ExtJs calls bindComponent during destroy (which still seems very strange to me). This was causing a rebind on destroy, which is not desirable.

@simonseyock simonseyock merged commit 9d955f5 into master Jun 10, 2021
@simonseyock simonseyock deleted the selection-model-tolerance branch June 10, 2021 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants