Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create .nojekyll file to allow JS files in node_modules on GH pages #691

Merged
merged 1 commit into from
Jun 22, 2021

Conversation

geographika
Copy link
Member

Example pages are currently broken as ol.js is in a node_modules folder.

GET https://geoext.github.io/geoext/master/node_modules/@geoext/openlayers-legacy/dist/ol.js net::ERR_ABORTED 404

This is ignored in GitHub Pages by default - see https://stackoverflow.com/questions/43481269/github-pages-404-on-node-modules-folder

Example pages are currently broken as ol.js is in a node_modules folder. This is ignored in GitHub Pages by default - see https://stackoverflow.com/questions/43481269/github-pages-404-on-node-modules-folder
@coveralls
Copy link

coveralls commented Jun 8, 2021

Pull Request Test Coverage Report for Build 919619361

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.056%

Totals Coverage Status
Change from base Build 885980754: 0.0%
Covered Lines: 1381
Relevant Lines: 1630

💛 - Coveralls

@marcjansen
Copy link
Member

Thanks let's give this a try

Copy link
Member

@marcjansen marcjansen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge

@marcjansen
Copy link
Member

Should the file live in the master branch or in the gh-pages branch?

@geographika
Copy link
Member Author

Should the file live in the master branch or in the gh-pages branch?

Looking at:

publish_dir: ./master
I think the contents of master is pushed to gh-pages each time so needs to be added to the root?

@geographika
Copy link
Member Author

Please merge

I think I only have merge permissions for geoext/geoext3 and not geoext/geoext

@marcjansen
Copy link
Member

Please merge

I think I only have merge permissions for geoext/geoext3 and not geoext/geoext

I have added you to a team which should have access. Please try again.

@geographika
Copy link
Member Author

I have added you to a team which should have access. Please try again.

Sorry still no merge button available!

@geographika geographika merged commit c749533 into geoext:master Jun 22, 2021
@marcjansen marcjansen mentioned this pull request Aug 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants