Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues when serializing OpenLayers icons for printing #719

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

marcjansen
Copy link
Member

@marcjansen marcjansen commented Dec 15, 2022

Without this the print example errors with

Uncaught DOMException: Failed to execute 'drawImage' on 'CanvasRenderingContext2D': The image argument is a canvas element with a width or height of 0.
    at Function.encodeVectorStylePoint (https://geoext.github.io/geoext/master/src//data/serializer/Vector.js?_dc=1671108261136:408:45)

The used print service has been updated as well, and now the example is working locally again, thanks @dnlkoch.

I think in a follow-up we should remove the option to use JSONP, it seems as this is no longer supported. We have the switch useJsonp already in teh code, so this can be circumvented in userland easily.

Please review.

@marcjansen marcjansen marked this pull request as ready for review December 20, 2022 10:49
@marcjansen
Copy link
Member Author

Thanks for the review.

@marcjansen marcjansen merged commit 192d655 into geoext:master Dec 20, 2022
@marcjansen marcjansen deleted the vector-print branch December 20, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants