Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrintMapPanel - resolutions from source map not properly copied #71

Open
justb4 opened this issue Jun 12, 2013 · 0 comments
Open

PrintMapPanel - resolutions from source map not properly copied #71

justb4 opened this issue Jun 12, 2013 · 0 comments

Comments

@justb4
Copy link
Contributor

justb4 commented Jun 12, 2013

A Heron user found an issue when using PrintMapPanel (via ux PrintPreview) with an "irregular" resolutions array for a TMS layer. Diving into this I found an old GeoExt ticket on Trac: http://trac.geoext.org/ticket/306. It appeared to be solved, but the committed code was taken out from PrintMapPanel in a later commit:

Patch went in this revision (see e.g. line 227):
https://github.com/geoext/geoext/blob/613eaa8836a13c88f727fbbfdbe5148c14604195/lib/GeoExt/widgets/PrintMapPanel.js

But went out, possibly by accident, in a next commit:
geoext/geoext@ac5de9a#lib/GeoExt/widgets/PrintMapPanel.js

I have made a fix for Heron which worked (just copying with slice(0) the resolutions array from the source map) by overriding PrintMapPanel.initComponent:
http://lib.heron-mc.org/heron/latest/lib/override-geoext.js

I can supply a patch/pull if you like. Possibly also affects GeoExt2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant