Add tests to detect leaked event bindings of vector legends.

geoext · Feb 24, 2015 · 18f0890 · 18f0890
1 parent 33af022
commit 18f0890
Showing 1 changed file with 31 additions and 7 deletions.
diff --git a/tests/panel/Legend.html b/tests/panel/Legend.html
@@ -145,7 +145,7 @@
         }
 
         function test_addremove(t) {
-            t.plan(4);
+            t.plan(8);
             var mapPanel = loadMapPanel();
             var lp  = Ext.create("GeoExt.panel.Legend", {
                 renderTo: 'legendpanel'});
@@ -167,12 +167,36 @@
             mapPanel.map.removeLayer(mapPanel.map.layers[0]);
             t.eq(lp.items.length, 2, "Removing the layer really removes the legend from the panel");
 
+            trouble = false;
+            try {
+                mapPanel.map.zoomIn();
+            } catch (err) {
+                trouble = true;
+            }
+            t.ok(!trouble, "Removed WMS layer did not leak event bindings");
+
+            layer = new OpenLayers.Layer.Vector('test4');
+            mapPanel.map.addLayer(layer);
+
+            t.eq(lp.items.length, 3, "A vector layer will be added");
+
+            mapPanel.map.removeLayer(layer);
+            t.eq(lp.items.length, 2, "Removing the vector layer really removes the legend from the panel");
+
+            trouble = false;
+            try {
+                mapPanel.map.zoomIn();
+            } catch (err) {
+                trouble = true;
+            }
+            t.ok(!trouble, "Removed vector layer did not leak event bindings");
+
             lp.destroy();
             mapPanel.destroy();
         }
-        
+
         function test_unsupported(t) {
-            
+
             t.plan(1);
             var mapPanel = Ext.create('GeoExt.panel.Map', {
                 title: "GeoExt MapPanel",
@@ -186,11 +210,11 @@
                 center: new OpenLayers.LonLat(5, 45),
                 zoom: 4
             });
-            
+
             var legendPanel = Ext.create("GeoExt.panel.Legend", {
                 renderTo: "legendpanel"
             });
-            
+
             var map = mapPanel.map;
             var layer = map.layers[1];
             var trouble;
@@ -200,10 +224,10 @@
                 trouble = true;
             }
             t.ok(!trouble, "removed layer without issues");
-            
+
             legendPanel.destroy();
             mapPanel.destroy();
-            
+
         }
 
         function test_clear(t) {