Add vertical and horizontal vane position controls #109

nathanjw · 2023-08-03T14:14:59Z

Add vertical and horizontal vane selects as done for Panasonic pumps; https://github.com/DomiStyle/esphome-panasonic-ac
Add HORIZONTAL and BOTH swing mode options in additon to OFF and VERTICAL
Fix logging bug causing ESP to crash

Starting from #103 by @seime, extract the vane implementation code and format according to existing style. Leave behind all the reformatting.

SSMCD

Confirmed working with my MSZ-FH09NA unit. Thank you!

Recommend disabling the swing mode trait of the climate component if these Horizontal and Vertical selects are used.
See Advanced Configuration:

supports:
  swing_mode: []

SSMCD · 2023-08-04T02:21:08Z

README.md

+    horizontal_vane_select:
+      name: Horizontal Vane Position
+    vertical_vane_select:
+      name: Horizontal Vane Position


horizontal_vane_select: name: ${name} Horizontal Vane vertical_vane_select: name: ${name} Vertical Vane

seime · 2023-08-04T15:18:15Z

README.md

I also added MSZ-FH35V as a verified working unit. Also tested fine with MSZ-LN35VG2W

This likely went away when I set the base branch to develop. Can you work with @nathanjw on that rebase?

swannet · 2023-09-04T12:41:09Z

I've tested this PR on my units (MSZ-AP**VGK, currently tested on MSZ-AP25GK and MSZ-AP55VGK, but the board is the same) and they are working as expected. I've used the by SSMCD on 4th august (line 231 > Horizontal Vane Position > ${name} Vertical Vane)

geoffdavis · 2023-09-04T16:31:47Z

Can you rebase this onto devel instead of master? I've got some pending commits on the devel branch that I need to package as a release. They're mostly documentation changes.

@seime

Starting from geoffdavis#103 by @seime, extract the vane implementation code and format according to existing style. Leave behind all the reformatting.

nathanjw · 2023-09-05T01:51:46Z

Rebased against devel, and caught up to the changes there. I also re-added the models that @seime mentioned.

geoffdavis

Most units don't support Horizontal or Both swing modes by default. Please leave the default set to ['OFF', 'VERTICAL']

README.md

components/mitsubishi_heatpump/climate.py

SGXander · 2023-12-18T21:54:30Z

Tested nathanjw:unformat-select and it's working well on MSZ-LN25VG2

Ferrox85 · 2023-12-28T12:52:03Z

Can this be merged? I Want to get rid of the MELCLOUD integration, but I need this kind of control to be able to do that..

geoffdavis · 2023-12-30T17:11:41Z

Can this be merged? I Want to get rid of the MELCLOUD integration, but I need this kind of control to be able to do that..

Not until the change I requested is made, and the conflicts are resolved.

SGXander · 2023-12-30T23:48:51Z

I've made a slight alteration at https://github.com/SGXander/esphome-mitsubishiheatpump/tree/split_fix which I'd be happy to PR either here or into nathanjws fork, let me know which. The underlying swicago library specifies "<>" which in nathanjws version is marked as "auto" but during testing I have discovered it is actually "split" (leaving the middle clear and sending air left and right). I've updated this in my fork under the split_fix branch but so far I haven't found the command code to activate auto on the horizontal_vane so have left it out of the options variable.
Edit: I'm giving up for the night but auto is not 0x00 like vertical (of course not) but it must be another value not listed as the select returns to default(left) when unset. I'll carry on looking tomorrow.

nathanjw · 2023-12-31T00:32:16Z

Please take another look. I had adjusted the defaults as requested, but missed that merge conflict. I think that is resolved now.

eclair4151 · 2024-01-02T19:43:30Z

Whats the best way to test this PR on my Home Assistant install? I tried replacing the external component URL with your branch URL, but it didnt seem to have any effect.

SGXander · 2024-01-02T20:04:38Z

Whats the best way to test this PR on my Home Assistant install? I tried replacing the external component URL with your branch URL, but it didnt seem to have any effect.

external_components:
  - source: github://nathanjw/esphome-mitsubishiheatpump@unformat-select

eclair4151 · 2024-01-05T03:07:14Z

Awesome, thanks! Just tested it out, working for me as well. I wish Home assistant let you customize the HVAC card to allow you to put the swing in the card, oh well :). @SGXander I think you still need to mark the PR ready for review.

SGXander · 2024-01-05T07:50:22Z

Awesome, thanks! Just tested it out, working for me as well. I wish Home assistant let you customize the HVAC card to allow you to put the swing in the card, oh well :). @SGXander I think you still need to mark the PR ready for review.

Not my repo, it's ready to merge already though if you want it to report "split" instead of "auto" then use my fork for now as I don't think nathanjw has updated this one.

eclair4151 · 2024-01-05T12:01:50Z

Ah whoops, @nathanjw thoughts on adding in support for horizontal vane split position in this PR and marking it ready for review?

SGXander · 2024-01-07T20:31:51Z

put in nathanjw#1 for the split thing that way it should update this PR if approved

eclair4151 · 2024-01-30T00:03:28Z

@nathanjw Whats the status on this? If we dont hear back should we just raise a separate PR based on yours SGXander which includes the fix?

nathanjw · 2024-01-30T00:53:36Z

I think I'd like to get this in as is and then a cosmetic renaming of that horizontal mode could be a much easier followon.

jamiebegin · 2024-01-30T00:56:12Z

Whats the best way to test this PR on my Home Assistant install? I tried replacing the external component URL with your branch URL, but it didnt seem to have any effect.
external_components:
  - source: github://nathanjw/esphome-mitsubishiheatpump@unformat-select

I'm getting a whole slew of errors when I attempt to compile using this branch. It starts with:

In file included from src/esphome.h:33,
                 from src/esphome/components/mitsubishi_heatpump/espmhp.h:20,
                 from src/esphome/components/mitsubishi_heatpump/espmhp.cpp:21:
src/esphome/components/mitsubishi_heatpump/espmhp.h:182:14: error: 'optional' in namespace 'std' does not name a template type
         std::optional<std::chrono::duration<long long, std::ratio<60>>> remote_operating_timeout_;

These errors don't happen when using the base branch. I'm not much of a C++ guy so I'm not sure where to start looking for the problem?

swannet · 2024-01-30T06:35:41Z

@jamiebegin

You have to add some options to help the compiler use C++17

See the sample below. You've to add the platformio_options with the build_unflag and build_flags

esphome:
  name: ${name}
  friendly_name: ${friendly_name}
  # Set platform options to use c++ 17 instead of 11
  platformio_options:
    build_unflags:
      - "-std=gnu++11"
    build_flags:
      - "-std=gnu++17"

davidcd13 · 2024-02-15T18:31:15Z

Vane selection cannot be integrated into the default home assistant climate card? Is it necessarily a separate card? With Melcloud, vane position is integrated into the default climate card.

swannet · 2024-03-16T16:30:45Z

Vane selection cannot be integrated into the default home assistant climate card? Is it necessarily a separate card? With Melcloud, vane position is integrated into the default climate card.

It is possible, with the "features" you can add to the climate card. And with the service-call-tile-feature add-on from Nerwyn (https://github.com/Nerwyn/service-call-tile-feature):

type: thermostat
entity: climate.airco_
features:
  - style: icons
    hvac_modes:
      - 'off'
      - cool
      - heat
      - fan_only
      - dry
    type: climate-hvac-modes
  - style: dropdown
    fan_modes:
      - auto
      - low
      - medium
      - high
    type: climate-fan-modes
  - type: custom:service-call
    entries:
      - type: selector
        entity_id: select.airco_horizontal_vane_position
        options:
          - option: left
            icon: mdi:chevron-double-left
          - option: left_center
            icon: mdi:chevron-left
          - option: center
            icon: mdi:format-horizontal-align-center
          - option: right_center
            icon: mdi:chevron-right
          - option: right
            icon: mdi:chevron-double-left
  - type: custom:service-call
    entries:
      - type: selector
        entity_id: select.airco_vertical_vane_position
        options:
          - option: up
            icon: mdi:chevron-double-up
          - option: up_center
            icon: mdi:chevron-up
          - option: center
            icon: mdi:format-vertical-align-center
          - option: down_center
            icon: mdi:chevron-down
          - option: down
            icon: mdi:chevron-double-down
show_current_as_primary: false

You can change the icons or options as you like.

complete adding changes to climate.py from pull request geoffdavis#109

per pull request geoffdavis#109

SSMCD reviewed Aug 4, 2023

View reviewed changes

seime reviewed Aug 4, 2023

View reviewed changes

geoffdavis changed the base branch from master to develop September 4, 2023 16:47

Modified patch for vane support.

53c3d88

Starting from geoffdavis#103 by @seime, extract the vane implementation code and format according to existing style. Leave behind all the reformatting.

nathanjw force-pushed the unformat-select branch from 0150144 to 53c3d88 Compare September 5, 2023 01:36

nathanjw added 2 commits September 4, 2023 21:39

Restore a couple of dropped tested models.

860307b

Catch up with use of explicit namespaces in header.

d04e617

geoffdavis mentioned this pull request Sep 20, 2023

Allow for setting vane position via MQTT #75

Closed

Merge branch 'develop' into unformat-select

224a1d9

geoffdavis mentioned this pull request Oct 13, 2023

Add vertical and horizontal vane position controls #103

Closed

geoffdavis changed the title ~~Modified patch for vane support.~~ Add vertical and horizontal vane position controls Oct 13, 2023

geoffdavis requested changes Oct 13, 2023

View reviewed changes

geoffdavis reviewed Oct 13, 2023

View reviewed changes

README.md Outdated Show resolved Hide resolved

geoffdavis reviewed Oct 13, 2023

View reviewed changes

components/mitsubishi_heatpump/climate.py Outdated Show resolved Hide resolved

geoffdavis and others added 2 commits October 13, 2023 14:00

Merge branch 'develop' into unformat-select

d42322e

Remove horizontal/both modes, which are uncommon, per request.

4a72392

Bascht74 mentioned this pull request Dec 30, 2023

Actual status of this component and the forks out in the wild #131

Closed

geoffdavis added the enhancement New feature or request label Dec 30, 2023

Merge branch 'develop' into unformat-select

562c7e7

nathanjw requested a review from geoffdavis January 30, 2024 00:51

cameroncros mentioned this pull request Jan 30, 2024

swing mode 1, 2, 3, 4, 5 #136

Closed

PapaMater added a commit to PapaMater/esphome-mitsubishiheatpump that referenced this pull request May 5, 2024

Update climate.py

d01805f

complete adding changes to climate.py from pull request geoffdavis#109

PapaMater added a commit to PapaMater/esphome-mitsubishiheatpump that referenced this pull request May 5, 2024

Update espmhp.cpp

2988e85

per pull request geoffdavis#109

PapaMater added a commit to PapaMater/esphome-mitsubishiheatpump that referenced this pull request May 5, 2024

Update espmhp.h

9385032

per pull request geoffdavis#109

PapaMater added a commit to PapaMater/esphome-mitsubishiheatpump that referenced this pull request May 5, 2024

Create mitsubishi_ac_select.h

73328a4

per pull request geoffdavis#109

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add vertical and horizontal vane position controls #109

Add vertical and horizontal vane position controls #109

nathanjw commented Aug 3, 2023 •

edited by geoffdavis

SSMCD left a comment •

edited

SSMCD Aug 4, 2023 •

edited

seime Aug 4, 2023

geoffdavis Sep 4, 2023

swannet commented Sep 4, 2023 •

edited

geoffdavis commented Sep 4, 2023

nathanjw commented Sep 5, 2023

geoffdavis left a comment

SGXander commented Dec 18, 2023

Ferrox85 commented Dec 28, 2023

geoffdavis commented Dec 30, 2023

SGXander commented Dec 30, 2023 •

edited

nathanjw commented Dec 31, 2023

eclair4151 commented Jan 2, 2024

SGXander commented Jan 2, 2024 •

edited

eclair4151 commented Jan 5, 2024

SGXander commented Jan 5, 2024

eclair4151 commented Jan 5, 2024

SGXander commented Jan 7, 2024

eclair4151 commented Jan 30, 2024

nathanjw commented Jan 30, 2024

jamiebegin commented Jan 30, 2024

swannet commented Jan 30, 2024

davidcd13 commented Feb 15, 2024

swannet commented Mar 16, 2024 •

edited

Add vertical and horizontal vane position controls #109

Are you sure you want to change the base?

Add vertical and horizontal vane position controls #109

Conversation

nathanjw commented Aug 3, 2023 • edited by geoffdavis

SSMCD left a comment • edited

Choose a reason for hiding this comment

SSMCD Aug 4, 2023 • edited

Choose a reason for hiding this comment

seime Aug 4, 2023

Choose a reason for hiding this comment

geoffdavis Sep 4, 2023

Choose a reason for hiding this comment

swannet commented Sep 4, 2023 • edited

geoffdavis commented Sep 4, 2023

nathanjw commented Sep 5, 2023

geoffdavis left a comment

Choose a reason for hiding this comment

SGXander commented Dec 18, 2023

Ferrox85 commented Dec 28, 2023

geoffdavis commented Dec 30, 2023

SGXander commented Dec 30, 2023 • edited

nathanjw commented Dec 31, 2023

eclair4151 commented Jan 2, 2024

SGXander commented Jan 2, 2024 • edited

eclair4151 commented Jan 5, 2024

SGXander commented Jan 5, 2024

eclair4151 commented Jan 5, 2024

SGXander commented Jan 7, 2024

eclair4151 commented Jan 30, 2024

nathanjw commented Jan 30, 2024

jamiebegin commented Jan 30, 2024

swannet commented Jan 30, 2024

davidcd13 commented Feb 15, 2024

swannet commented Mar 16, 2024 • edited

nathanjw commented Aug 3, 2023 •

edited by geoffdavis

SSMCD left a comment •

edited

SSMCD Aug 4, 2023 •

edited

swannet commented Sep 4, 2023 •

edited

SGXander commented Dec 30, 2023 •

edited

SGXander commented Jan 2, 2024 •

edited

swannet commented Mar 16, 2024 •

edited