Remove executable bit from tests #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you resolve the merge conflict + I'll merge? |
|
Sure, no worries. |
added 2 commits
October 26, 2015 16:05
These files should normally be run through `Module::Build`'s `test` command and not called as standalone scripts. Hence they don't need a shebang line.
Test scripts should be run via the `Module::Build` `test` command, not as standalone scripts. Hence they don't require the executable bit set.
paultcochrane
force-pushed
the
pr/remove-exec-bit-from-tests
branch
from
ec423d7
to
a9d8cdf
Compare
|
Ok, all fixed and pushed and ready to be merged :-) |
geofffranks
added a commit
that referenced
this pull request
Oct 26, 2015
Remove executable bit from tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test scripts should usually be run via the relevant test runner and not as standalone scripts, hence the test scripts don't need to have the executable bit set.