[2.3.1] PayPal Checkout not populating Total Fees

[jimpdx]

Version: 2.3.1
Self Hosted Installation URL: https://fallclassic.oregonbrewcrew.org

Description of Issue:
I noticed today (when paying for my own entries in 2.3.1 that clicking "Pay with PayPal" was not pre-populating the "Total Fees" variable that I think you are still sending in your code (ref: https://github.com/geoffhumphrey/brewcompetitiononlineentry/blob/master/sections/pay.sec.php#L178)

We have been using PayPal in BCOEM without any issues for years. Unless I am crazy, this is the first time the payment form did not pre-populate the amount and asked me to enter it? Seems like it would allow participants to easily pay the wrong amount?

This could be a change on the PayPal side of things, as I know the code has not been updated in some time. I didn't see any other open issues relating to this so I thought I might bring it up? I am happy to research further if you have any PP resources/dev guides I can look over.

[jimpdx]

Actually I checked the source and the hidden variable is not being populated by the code internally:

 <input type="hidden" name="action" value="add_form" />
 <input type="hidden" name="cmd" value="_xclick">
 <input type="hidden" name="business" value="treasurer@oregonbrewcrew.org">
 <input type="hidden" name="item_name" value="Thompson, Jim - 2021 Oregon Brew Crew Fall Classic - PayPal Payment">
 <input type="hidden" name="amount" value="">
 <input type="hidden" name="currency_code" value="USD">
 <input type="hidden" name="button_subtype" value="services">
 <input type="hidden" name="no_note" value="0">
 <input type="hidden" name="cn" value="Add special instructions">
 <input type="hidden" name="no_shipping" value="1">
 <input type="hidden" name="rm" value="1">
 <input type="hidden" name="custom" value="1\|134">
 <input type="hidden" name="return" value="https://fallclassic.oregonbrewcrew.org/index.php?section=pay&msg=10">
 <input type="hidden" name="cancel_return" value="https://fallclassic.oregonbrewcrew.org/index.php?section=pay&msg=11">
 <input type="hidden" name="bn" value="PP-BuyNowBF:btn_paynowCC_LG.gif:NonHosted">
 <button type="button" name="btn" id="submitBtn" data-toggle="modal" data-target="#confirm-submit" class="btn btn-primary" /><span class="fa fa-paypal"></span> Pay with PayPal</button>

[jimpdx]

So just messing around with the code locally, this change seems to have fixed the issue for me?
#1246

[geoffhumphrey]

Confirmed, and thank you for reporting and providing the fix, @jimpdx. For those experiencing this issue, implement the fix described in pull #1246 or download the latest master commit and upload/replace the /sections/pay.sec.php file to your server.

[grmelacz]

I think this bug might be connected with one that just happened at our competition today. One of the contestants has 2 entries in the competition but the received payment was just for one. He confirmed he payed just for one, though the note in the PayPal transactions displays two: 238|107-108. The problem is both entries were marked as payed though the total was not correct!

I don't wanna hijack this thread, so in case this is a separate problem, please move my comment to a new thread accordingly.

[geoffhumphrey]

Hello @grmelacz, this could be related if you're not adding the PayPal fees to the entrant's total. The code described in pull #1246 provides a fix.

[grmelacz]

Yes, I do not have adding fees enabled. Makes sense. I've already applied the mentioned fix, will let you know if the bug occurs again. Thanks!