Fix placement of LIMIT OFFSET clauses for gridsize and where subselects #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 20 20
Lines 3519 3519
=======================================
Hits 3269 3269
Misses 250 250
☔ View full report in Codecov by Sentry. |
theroggy
deleted the
Fix-placement-of-LIMIT-OFFSET-clauses-for-gridsize-and-where-subselects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "LIMIT -1 OFFSET 0 " meant to avoid the subquery flattening was placed after the outer query instead of in the subquery... so didn't do a lot...