attempt to reduce cognitive complexity setButton method of GroupRecyc…

…lerActivity
geofot96 · Nov 13, 2018 · cc5fd9b · cc5fd9b
1 parent 280e4eb
commit cc5fd9b
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/app/src/main/java/ch/epfl/sweng/studdybuddy/util/GroupsRecyclerAdapter.java b/app/src/main/java/ch/epfl/sweng/studdybuddy/util/GroupsRecyclerAdapter.java
@@ -162,18 +162,23 @@ private void setButton(Button button, Group group){
             groupSize = gSize.intValue();
         }
         button.setText("Join");
-        Pair pair =new Pair(userId, group.getGroupID().toString());
+        //Pair pair =new Pair(userId, group.getGroupID().toString());
         if(groupSize < group.getMaxNoUsers()
                 &&!uGroupIds.contains(group.getGroupID().getId())) {
             button.setText("Join");
             button.setOnClickListener(joinButtonListener(group, button));
         }else {
             button.setText("More Info");
-            if (uGroupIds.contains(group.getGroupID().getId())) {
-                button.setOnClickListener(moreInfoListenerIfInTheGroup(button, group));
-            } else {
-                button.setOnClickListener(moreInfoListener(button, group.getGroupID().getId()));
-            }
+            getTheRightMoreInfo(button, group, uGroupIds.contains(group.getGroupID().getId()));
+
+        }
+    }
+
+    private void getTheRightMoreInfo(Button button, Group group, boolean contains) {
+        if (contains) {
+            button.setOnClickListener(moreInfoListenerIfInTheGroup(button, group));
+        } else {
+            button.setOnClickListener(moreInfoListener(button, group.getGroupID().getId()));
         }
     }