Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install on arch (and python2 systems) #140

Merged
merged 5 commits into from Jan 31, 2016
Merged

Fix install on arch (and python2 systems) #140

merged 5 commits into from Jan 31, 2016

Conversation

xtrm0
Copy link
Contributor

@xtrm0 xtrm0 commented Jan 31, 2016

Install wasn't working on arch.
With this patch it works again.

On pacman the --needed directive prevents from reinstalling base-devel and python2-pip everytime the install script is run (most users will already have this packages and don't want to reinstall them :P)
Also added the --noconfirm to pacman, and the -y to yum
Fixed build_qemu.sh for arch
@nedwill
Copy link
Contributor

nedwill commented Jan 31, 2016

My system (OS X) has pip2 but not virtualenv2.

See turbulenz/turbulenz_engine#39.

I think the right thing to do is check for the existence of virtualenv2 and fallback to virtualenv if it's not present.

@xtrm0
Copy link
Contributor Author

xtrm0 commented Jan 31, 2016

Going to fix that now

@xtrm0
Copy link
Contributor Author

xtrm0 commented Jan 31, 2016

I think it is ok now

@nedwill
Copy link
Contributor

nedwill commented Jan 31, 2016

On the pacman line where you install python2-virtualenv, does this install virtualenv2? Perhaps the virtualenv2 check should come after it's potentially installed.

@xtrm0 xtrm0 changed the title Patch 1 Fix install on arch (and python2 systems) Jan 31, 2016
@xtrm0
Copy link
Contributor Author

xtrm0 commented Jan 31, 2016

nedwill I made the virtualenv checks to mimic the pip2 checks. Going to fix now

@xtrm0
Copy link
Contributor Author

xtrm0 commented Jan 31, 2016

(done)

@nedwill
Copy link
Contributor

nedwill commented Jan 31, 2016

This looks good. I'll trust you on the qemu_build.sh changes too since it works in Travis. Thanks!

nedwill added a commit that referenced this pull request Jan 31, 2016
Fix install on arch (and python2 systems)
@nedwill nedwill merged commit b939b6e into geohot:master Jan 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants