Fix custom data path behavior #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `path.join` just joins the path segments, not allowing the use of absolute paths
|
@bluesmoon Please update to npm, thank you very much. |
Trallp
pushed a commit
to privateJets/node-geoip
that referenced
this pull request
Mar 6, 2024
- `path.join` just joins the path segments, not allowing the use of absolute paths After this update, you can use * absolute paths in the updater * process.env.GEODATADIR for specifying the custom data dir for library Co-authored-by: Jakub Jandl <jakub.jandl@emplifi.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The custom data path behavior is inconsistent between the updater and library itself.
In the updater, a path relative to
CWDhsa to be provided, there is no support for absolute paths.In the library, the only way of specifying a custom data path is using the very clunky
global.geodatadir, while updater can use env variable.After this update, you can use
process.env.GEODATADIRfor specifying the custom data dir for library