-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed sql function type #146
Conversation
lib/geokit-rails/adapters/sqlite.rb
Outdated
@@ -3,7 +3,7 @@ module Adapters | |||
class SQLite < Abstract | |||
|
|||
def self.add_numeric(name) | |||
@@connection.create_function name, 1, :numeric do |func, *args| | |||
@@connection.create_function name, 1, SQLite3::Constants::TextRep::ANY do |func, *args| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics/LineLength: Line is too long. [95/80]
lib/geokit-rails/adapters/sqlite.rb
Outdated
name, | ||
1, | ||
SQLite3::Constants::TextRep::ANY | ||
do |func, *args| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint/Syntax: unexpected token kDO
Lint/Syntax: unexpected token tPIPE
@@connection.create_function name, 1, :numeric do |func, *args| | ||
@@connection.create_function | ||
name, | ||
1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lint/Syntax: unexpected token tCOMMA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Tests pass when this change is implemented.
I've fixed this in another pull request and merged this fix into master. Thank you for the pull request and working on getting this fixed for everyone! |
No description provided.