Geo Scope method added #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geo_scope method added
| units = extract_units_from_options(options) | ||
| formula = extract_formula_from_options(options) | ||
| bounds = extract_bounds_from_options(options) | ||
|
|
|
A few things. Can you tell me why it should support an old method? Once you've done that you'll need to add appropriate tests and the method itself looks a bit complex so perhaps sub-components should become private methods or the method could be extracted into a class. |
|
Closed as it's got conflicts, and it was failing tests. If you can rebase this off master, resolve conflicts, and the tests pass I'll reconsider the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the geo_scope method for old gem support.