Make geocode_ip_address consistent #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`retrieve_location_from_cookie_or_service` would return a `GeoLoc` if the location was not cached, and a `Hash` if it was. Now a `GeoLoc` object is returned regardless.
| def retrieve_location_from_cookie_or_service | ||
| return YAML.load(cookies[:geo_location]) if cookies[:geo_location] | ||
| return GeoLoc.new(YAML.load(cookies[:geo_location])) if cookies[:geo_location] |
mnoack
pushed a commit
that referenced
this pull request
Oct 9, 2015
Make geocode_ip_address consistent
|
Thanks @thomdixon |
|
No problem! Thanks for the awesome lib! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
retrieve_location_from_cookie_or_servicewould return aGeoLocif the location was not cached, and a
Hashif it was. Now aGeoLocobject is returned regardless.