Add NOT NULL checks for latitude and longitude #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lues are being returned for distance calculations involving such objects.
| end | ||
|
|
||
| def not_null | ||
| where("#{qualified_lat_column_name} IS NOT NULL AND #{qualified_lng_column_name} IS NOT NULL") |
…lues are being returned for distance calculations involving such objects.
| @@ -137,7 +137,11 @@ def by_distance(options = {}) | |||
| bounds = extract_bounds_from_options(options) | |||
| distance_column_name = distance_sql(origin, units, formula) | |||
| #geo_scope(options).order("#{distance_column_name} asc") | |||
| order("#{distance_column_name} #{options[:reverse] ? 'DESC' : 'ASC'}") | |||
| not_null_latlng.order("#{distance_column_name} #{options[:reverse] ? 'DESC' : 'ASC'}") | |||
| @@ -140,7 +140,11 @@ def by_distance(options = {}) | |||
| bounds = extract_bounds_from_options(options) | |||
| distance_column_name = distance_sql(origin, units, formula) | |||
| #geo_scope(options).order("#{distance_column_name} asc") | |||
| order("#{distance_column_name} #{options[:reverse] ? 'DESC' : 'ASC'}") | |||
| with_latlng.order("#{distance_column_name} #{options[:reverse] ? 'DESC' : 'ASC'}") | |||
|
Please look at the Travis CI failures, they are not caused by my code. Thanks! |
mnoack
pushed a commit
that referenced
this pull request
Nov 9, 2015
Add NOT NULL checks for latitude and longitude
|
You're right. I tried to have a quick look at the CI failures but it seems it's getting rather complex and I'll need to spend some time ensuring it works correctly in all ruby/rails versions before I release the next version of the gem. |
|
Good :-), because I have another PR pending (add bounding box around |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... otherwise nonsense values are being returned for distance calculations involving such objects.
Added a test fixture without latitude and longitude to make existing tests fail if they do not test for NULL lat/lng values.