Add bounding box around within calls to speed up SQL request
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #geo_scope(options) | ||
| with_latlng.where(distance_conditions(options)) | ||
| # Add bounding box to speed up SQL request. | ||
| bounds = formulate_bounds_from_distance(options, |
| @@ -293,7 +293,7 @@ def test_ip_geocoder_exception | |||
| end | |||
|
|
|||
| def test_address_geocode | |||
| Geokit::Geocoders::MultiGeocoder.expects(:geocode).with('Irving, TX').returns(@location_a) | |||
| Geokit::Geocoders::MultiGeocoder.expects(:geocode).with('Irving, TX').twice.returns(@location_a) | |||
There was a problem hiding this comment.
Line is too long. [100/80]
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
| # Add bounding box to speed up SQL request. | ||
| bounds = formulate_bounds_from_distance( | ||
| options, | ||
| normalize_point_to_lat_lng(options[:origin]), |
mnoack
pushed a commit
that referenced
this pull request
Nov 10, 2015
Add bounding box around `within` calls to speed up SQL request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch speeds up SQL requests with a radius calculation (in my case 800ms -> 50ms on average) by adding a rectangular bounding box to all
withincalls onacts_as_mappableobjects. This used to be the default for Rails 3, it seems to have been lost in the conversion to ARel. Here it is again.