fix-Mysql2AdapterUndefinedMethodLoaded #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mysql2 was present in Adapters.constants as a Module, and require was never called, resulting in Undefined method exception. Make sure the require is called if the const_get returns a Module and not a Class
| @@ -98,6 +98,13 @@ def adapter | |||
| require File.join("geokit-rails", "adapters", filename) | |||
| end | |||
| klass = Adapters.const_get(connection.adapter_name.camelcase) | |||
| if klass.class == Module | |||
| # For some reason Mysql2 adapter was defined in Adapters.constants but was Module instead of a Class | |||
|
@IgorMiller Sorry for not getting back to your PR, now merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mysql2 was present in Adapters.constants as a Module, and require was never called, resulting in Undefined method exception. Make sure the require is called if the const_get returns a Module and not a Class.
Fix to the issue: #89
Do you think this is a good fix? Thanks.