Update geo_loc.rb #199
Merged
Update geo_loc.rb #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes this issue: geokit/geokit-rails#113
houndci-bot
reviewed
Jan 15, 2017
|
|
||
| # sanatises the GeoLoc object so that it conforms to [] | ||
| h = h.to_hash | ||
|
|
houndci-bot
reviewed
Jan 15, 2017
| @@ -49,7 +49,10 @@ def province | |||
| # Constructor expects a hash of symbols to correspond with attributes. | |||
| def initialize(h = {}) | |||
| @all = [self] | |||
|
|
|||
|
|
|||
2 similar comments
|
We are using @jamesstonehill's branch successfully until this is merged. Thanks James! |
|
Seeing geokit/geokit-rails#113 in production. Any thoughts on getting this merged? |
|
I think when this was first done I looked at it and could see that it worked, but had a feeling there was a better way. But I never got around to it so I'll merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this issue: geokit/geokit-rails#113