Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make geokit frozen string friendly #211

Merged
merged 1 commit into from May 7, 2018
Merged

Conversation

vvondra
Copy link
Contributor

@vvondra vvondra commented Feb 16, 2018

https://freelancing-gods.com/2017/07/27/friendly-frozen-string-literals.html

Avoids errors like

     Failure/Error: geo_address = Geokit::Geocoders::GoogleGeocoder.reverse_geocode("#{self.latitude},#{self.longitude}")
     
     FrozenError:
       can't modify frozen String

@coveralls
Copy link

coveralls commented Feb 16, 2018

Coverage Status

Coverage remained the same at 96.285% when pulling 125d031 on vvondra:frozen_friendly into 51cfd6c on geokit:master.

@mnoack mnoack merged commit 2bfab66 into geokit:master May 7, 2018
@mnoack
Copy link
Member

mnoack commented May 7, 2018

Thanks @vvondra - I don't normally cut releases straight away (I like to let people point to master and test against production for a bit and wait for other changes to bundle into a release)

@vvondra vvondra deleted the frozen_friendly branch May 10, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants