Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request - Rate limit export*.php #12

Closed
Tracked by #618
kumy opened this issue Mar 13, 2018 · 6 comments
Closed
Tracked by #618

Feature Request - Rate limit export*.php #12

kumy opened this issue Mar 13, 2018 · 6 comments
Labels
enhancement New feature or request new-theme released

Comments

@kumy
Copy link
Member

kumy commented Mar 13, 2018

We started to talk about that in #10 and #11.

The export*.php are quite time consuming. We should deploy some kind of rate limiting on those endpoints.

It seems possible to achieve this using NGinx

Some partners should be able to do lot of queries to synchronize their database. This include at least opencaching* sites, geokretymap.org.
@kumy kumy added enhancement New feature or request good first issue Good for newcomers labels Mar 13, 2018
@kumy kumy mentioned this issue Mar 13, 2018
Closed
@kumy
Copy link
Member Author

kumy commented Mar 13, 2018

Link to geokrety/geokrety-api#27 for the Api-NG issue.

@kumy
Copy link
Member Author

kumy commented Mar 13, 2018

The production instance use Apache2 at the moment…

@kumy
Copy link
Member Author

kumy commented Mar 13, 2018

An example of rate limit on GKM

@romain-dartigues
Copy link

Or HAProxy ref,
or Redis.

A full protection should probably:

  • limit per IP when no API was given
  • limit per API (avoid DDoS)
  • global limit per endpoint (disable only part of the website to protect the others services)

@kumy
Copy link
Member Author

kumy commented Apr 15, 2018

Next Traefik version will support basic ratelimiting with labels

https://docs.traefik.io/v1.6/configuration/commons/#rate-limiting

@kumy kumy mentioned this issue Jun 25, 2019
Closed
@kumy kumy added new-theme and removed good first issue Good for newcomers labels Jan 3, 2022
@kumy kumy mentioned this issue Jan 3, 2022
Closed
39 tasks
kumy added a commit that referenced this issue Mar 10, 2022
@kumy
feat: Add request limits on endpoints
fae4f3a 
Fix #12, #421
github-actions bot pushed a commit that referenced this issue Mar 10, 2022
@geokrety-bot
ci(release): 2.17.0
a0e91f2 
## [2.17.0](v2.16.2...v2.17.0) (2022-03-10)

### Features

* Add request limits on endpoints ([fae4f3a](fae4f3a)), closes [#12](#12) [#421](#421)

### Bug Fixes

* Another database-migrator fix ([00d38d2](00d38d2))
* Try to fix map autobound one more time ([90f951b](90f951b))

### Performance Improvements

* Enhance a geojson database query ([6096976](6096976))

### Code Refactoring

* Symplify a test condition ([fb10d89](fb10d89))

### Style

* Migrate go2geo to bootstrap ([bf2c221](bf2c221))
@geokrety-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 2.17.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kumy kumy closed this as completed Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request new-theme released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kumy @romain-dartigues @geokrety-bot