-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translations for country and cache types #32
Comments
Hum, nice catch. Those comes directly from the database. The database is synchronized from different opencaching sites. First step would be to synchronize those with English terms instead of "native opencaching site language"? Then we can think of a way to translate. It'll not be that easy. @harrieklomp please don't be frustrated if we don't fix this using the current website. @harrieklomp, @boly38 If you agree, I would close it as "Won't do - in current site version". |
@boly38 would you open a pull request / post a picture of the result? |
yep (next week) 🙃 |
My personal draft / note:
todo list before PR:
|
Hi @kumy . about this usecase: waypoint search gives one result, example: In this case, Exemple:
What do you think about using some kind of dynamic translation for theses 2 fields values ?
In our dictionary we will have some entries starting with prefix "WPTYP_" or "WPKRAJ_" to make frontier between waypoint data related entries and geokrety website legacy entries. Seems the distinct values for this 2 fields are not so big: 10 cache type (Typ) and 35 country (kraj) This result in adding 45 entry to crowdin. What do you think ? |
Yep, go for it. Don't forget to add new strings "in English" and probably in a dedicated file as current strings are extracted from source code and not database… A |
…nty::kraj; opencaching code first; better wording when limit to N results; add translation for search with less than 5 chars
not understand that point, sorry |
The strings uploaded to crowdin are - until now - extracted from source code using geokrety-website/scripts/export-translations-github.sh Lines 27 to 29 in 8367a4d
If I'm not mistaken, you want to translate some strings that come from the database (table So, I suggest to extract/copy those 45 strings out of the database as a static file, as Of course, the strings in the database need to be translated into English first, and also be in English in the |
ok thanks for your lights. I will see that and follow this way 🤸 |
hey, finally we have got 110 countries (result in 79 unique english translations) See geokrety-website/docker/mariadb/gk-waypointy-country.sql Lines 12 to 121 in 754b82a
19 cache types (result in 14 unique english translations) See geokrety-website/docker/mariadb/gk-waypointy-type.sql Lines 12 to 30 in 754b82a
You could put an eye to see any error. Next step: crowdin input @kumy following you advice, and out of error, seems we are not already using |
So I think we're no so far (for translations only, I need to work a little bit more on webpage) is generated by |
Use crowdin translations for waypointy::typ and waypointy::kraj - add 2 tables to mysql schema - add waypointy-translations.html generated smarty template cf. geokrety-scripts / waypointy /oc / waypointy-translations.php Update ruchy.php UI - when multiple caches as result: opencaching code first - add translation for search error when name is less than 5 chars - better wording when limit to N results - start with PHPOO : lib/Waypointy ; fix szukaj-ajax.php ; Docker scripts - improve update.sh : onefile arg, alias, die error message - improve install.sh : fix first time exit 1 Travis - check crlf : ignore .(*)
Use crowdin translations for waypointy::typ and waypointy::kraj - add 2 tables to mysql schema - waypointy-translations.html must be generated using php: cf. geokrety-scripts / waypointy /oc / waypointy-translations.php Update ruchy.php UI - when multiple caches as result: opencaching code first - add translation for search error when name is less than 5 chars - better wording when limit to N results - start with PHPOO : lib/Waypointy ; fix szukaj-ajax.php ; use prepared statement Docker scripts - improve update.sh : onefile arg, alias phplogs phplogsf, die error message - improve install.sh : fix first time exit 1 - update SQL schema creation with legacy one Travis - check crlf : ignore .(*) - phpcs using bracket on same line rule Co-authored-by: Mathieu Alorent <github@kumy.net>
Use crowdin translations for waypointy::typ and waypointy::kraj - add 2 tables to mysql schema - waypointy-translations.html must be generated using php: cf. geokrety-scripts / waypointy /oc / waypointy-translations.php Update ruchy.php UI - when multiple caches as result: opencaching code first - add translation for search error when name is less than 5 chars - better wording when limit to N results - start with PHPOO : lib/Waypointy ; fix szukaj-ajax.php ; use prepared statement Docker scripts - improve update.sh : onefile arg, alias phplogs phplogsf, die error message - improve install.sh : fix first time exit 1 - update SQL schema creation with legacy one Travis - check crlf : ignore .(*) - phpcs using bracket on same line rule Co-authored-by: Mathieu Alorent <github@kumy.net>
Use crowdin translations for waypointy::typ and waypointy::kraj - add 2 tables to mysql schema - waypointy-translations.html must be generated using php: cf. geokrety-scripts / waypointy /oc / waypointy-translations.php Update ruchy.php UI - when multiple caches as result: opencaching code first - add translation for search error when name is less than 5 chars - better wording when limit to N results - start with PHPOO : lib/Waypointy ; fix szukaj-ajax.php ; use prepared statement Docker scripts - improve update.sh : onefile arg, alias phplogs phplogsf, die error message - improve install.sh : fix first time exit 1 - update SQL schema creation with legacy one Travis - check crlf : ignore .(*) - phpcs using bracket on same line rule Co-authored-by: Mathieu Alorent <github@kumy.net>
Use crowdin translations for waypointy::typ and waypointy::kraj - add 2 tables to mysql schema - waypointy-translations.html must be generated using php: cf. geokrety-scripts / waypointy /oc / waypointy-translations.php Update ruchy.php UI - when multiple caches as result: opencaching code first - add translation for search error when name is less than 5 chars - better wording when limit to N results - start with PHPOO : lib/Waypointy ; fix szukaj-ajax.php ; use prepared statement Docker scripts - improve update.sh : onefile arg, alias phplogs phplogsf, die error message - improve install.sh : fix first time exit 1 - update SQL schema creation with legacy one Travis - check crlf : ignore .(*) - phpcs using bracket on same line rule Co-authored-by: Mathieu Alorent <github@kumy.net>
Use crowdin translations for waypointy::typ and waypointy::kraj - add 2 tables to mysql schema - waypointy-translations.html must be generated using php: cf. geokrety-scripts / waypointy /oc / waypointy-translations.php Update ruchy.php UI - when multiple caches as result: opencaching code first - add translation for search error when name is less than 5 chars - better wording when limit to N results - start with PHPOO : lib/Waypointy ; fix szukaj-ajax.php ; use prepared statement Docker scripts - improve update.sh : onefile arg, alias phplogs phplogsf, die error message - improve install.sh : fix first time exit 1 - update SQL schema creation with legacy one Travis - check crlf : ignore .(*) - phpcs using bracket on same line rule Co-authored-by: Mathieu Alorent <github@kumy.net>
Use crowdin translations for waypointy::typ and waypointy::kraj - add 2 tables to mysql schema - waypointy-translations.html must be generated using php: cf. geokrety-scripts / waypointy /oc / waypointy-translations.php Update ruchy.php UI - when multiple caches as result: opencaching code first - add translation for search error when name is less than 5 chars - better wording when limit to N results - start with PHPOO : lib/Waypointy ; fix szukaj-ajax.php ; use prepared statement Docker scripts - improve update.sh : onefile arg, alias phplogs phplogsf, die error message - improve install.sh : fix first time exit 1 - update SQL schema creation with legacy one Travis - check crlf : ignore .(*) - phpcs using bracket on same line rule Co-authored-by: Mathieu Alorent <github@kumy.net>
Could it be possible to add translations for countries and cache types?
![selectie_156](https://user-images.githubusercontent.com/1060518/38429724-81d6691a-39bf-11e8-9d21-f82e97e817a7.png)
The text was updated successfully, but these errors were encountered: